Support context configurations (spatial/temporal subsets) and climatology-derived-configs. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ability to pass JSON/YAML strings and String.IO objects into loader Starting to move to the new style YAML loading in `ruamel.yaml`
This is for backwards compat. No test changes... it works the same way.
50% test effort
This allows for namedtuple defaults, which are my fav
# Conflicts: # docs/source/usage.rst # requirements.txt
…sults This change allows us to better handle additional Streams (that actually stream) and Stores (that can write based on a generator and not a very confusing dict structure). This is a huge change and is not backwards compatible with previous Stream or Store code. To get the functionality of the old return style, you need to first collect any results using `ioos_qc.results.collect_results(results, how='dict')`. See all of the test changes for examples. This does NOT affect anyone that was using the QC checks directly or was using QcConfig.run() or NcQcConfig.run(), both of which remain backwards compatible.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseding #33
This combines the work @yosoyjay worked on for generating configurations based on climatology datasets and the work I've been doing to add support for contextual QC configurations (temporal and spatial subsets).
Left to do:
ioos_qc