Fix Travis-CI #49
Fix Travis-CI #49
Conversation
| import sys | ||
|
|
||
| from setuptools import setup, find_packages | ||
| from setuptools.command.test import test as TestCommand | ||
|
|
||
| from pyoos import __version__ | ||
| def extract_version(module='pyoos'): |
There was a problem hiding this comment.
i've seen this pattern used somewhere else - can you explain what it's accomplishing and why it's better than the simpler import version?
There was a problem hiding this comment.
This pattern avoids importing the module before installing it. It does add some complexity, but it helps some packaging tools. For example: if this is not there we need to install all the dependencies at build time, which is not always desirable.
However, that is not essential and not the main point of this PR. I can remove that if you wish.
|
Fix #36 |
|
The And maybe the |
ocefpaf
force-pushed
the
fix_travis
branch
2 times, most recently
from
f31b287
to
46c5bc8
Compare
|
I fixed all but See https://travis-ci.org/ioos/pyoos/jobs/91659664#L372-L378 |
|
@ocefpaf, I'm very familiar with Unfortunately I can't follow up right now b/c I'm still in meetings. I have a hunch as to what could be causing failures in automatic tests, but I don't have time right now to follow up. Maybe Wednesday evening ... |
|
I'm happy to merge this without it fully passing and addressing NERRS separately, @ocefpaf . |
|
Sounds good! |
|
Thanks @daf you were faster than I 😉 |
|
NERRS tests probably fail because the code assumes they allow your IP address to access their service. Emilio's PR addresses this by adding the token based auth. Someone will need to get a token from NERRS to use in testing. |
That was exactly my hunch.
I have a token, but I don't feel at liberty to place it in a publicly visible location. FYI, that access option was developed by NERRS/CDMO last year partly through my nudging. Last time I asked them (last year), they were not comfortable opening it up for wider use. I/we should ask/encourage them again ... |
Looks like it's merged already, right? Cool! I can rebase on my end next week. But the testing will still be tricky, b/c of the issue @kwilcox mentioned, and b/c I'm reluctant to place my auth token in a publicly visible location w/o NERRS/CDMO's blessing. |
|
Maybe we should add a known failure or skip flag to those tests. @kwilcox thoughts? |
|
@emiliom Since you have connections with the CDMO group already, would you mind contacting them and asking for a token to be used in testing only (very limited usage). We can encrypt it into the .travis.yml to prevent abuse. Other than that... we need someone who is wiling to port |
Will do.
Ah, excellent! That will address the concern.
Heh. Not me. First I have to start using py3 ... |
See #52 |
|
👍 |
In order to investigate SECOORA/skill_score#225 I am coming back to pyoos a lot, so we need to get Travis-CI back online.
pyoosbuilds on Python 3, but is far from py3k compliant. There is a significant amount of work to do. I am deleting the pyoos python3 binaries from the ioos channel.Ping @kwilcox, @rsignell-usgs, and @vembus.