-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Travis-CI #49
Merged
Merged
Fix Travis-CI #49
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,33 +1,23 @@ | ||
sudo: false | ||
language: python | ||
python: | ||
- "2.7" | ||
|
||
env: | ||
- CONDA="python=2.7" | ||
- CONDA="python=3.4" | ||
- CONDA="python=3.5" | ||
|
||
before_install: | ||
# Install miniconda | ||
# ----------------- | ||
- export CONDA_BASE=http://repo.continuum.io/miniconda/Miniconda | ||
- if [[ "$TRAVIS_PYTHON_VERSION" == 2* ]]; then | ||
wget ${CONDA_BASE}-3.7.0-Linux-x86_64.sh -O miniconda.sh; | ||
else | ||
wget ${CONDA_BASE}3-3.7.0-Linux-x86_64.sh -O miniconda.sh; | ||
fi | ||
- bash miniconda.sh -b -p $HOME/miniconda | ||
- export PATH="$HOME/miniconda/bin:$PATH" | ||
- wget http://bit.ly/miniconda -O miniconda.sh | ||
- bash miniconda.sh -b -p $HOME/miniconda | ||
- export PATH="$HOME/miniconda/bin:$PATH" | ||
- conda update --all --yes | ||
- conda config --add channels ioos -f | ||
- travis_retry conda create --yes -n test $CONDA --file requirements.txt | ||
- source activate test | ||
- travis_retry conda install --yes pytest | ||
|
||
# Create the basic testing environment | ||
# ------------------------------------ | ||
- conda config --set always_yes yes --set changeps1 no | ||
- conda config --set show_channel_urls True | ||
- conda update --quiet conda | ||
- ENV_NAME='test-environment' | ||
- conda create --quiet -n $ENV_NAME python=$TRAVIS_PYTHON_VERSION | ||
- source activate $ENV_NAME | ||
script: | ||
- py.test -vv | ||
|
||
install: | ||
# Customise the testing environment | ||
# --------------------------------- | ||
- conda install --channel https://conda.binstar.org/rsignell --file requirements.txt | ||
- conda install pytest | ||
script: py.test -vv | ||
notifications: | ||
flowdock: 2dd835dfbdbc64986ba043fffa654836,1d5af475ae38ec1d874c752c23558d2d | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've seen this pattern used somewhere else - can you explain what it's accomplishing and why it's better than the simpler import version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pattern avoids importing the module before installing it. It does add some complexity, but it helps some packaging tools. For example: if this is not there we need to install all the dependencies at build time, which is not always desirable.
However, that is not essential and not the main point of this PR. I can remove that if you wish.