Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish incomplete code and usage in helper class __Plugins__ #177

Closed
XerTheSquirrel opened this issue Sep 19, 2018 · 0 comments
Closed

Finish incomplete code and usage in helper class __Plugins__ #177

XerTheSquirrel opened this issue Sep 19, 2018 · 0 comments
Assignees
Labels
bug Something that is not working correctly! review In review or needs reviewing
Milestone

Comments

@XerTheSquirrel
Copy link
Contributor

In com.iopipe.__Plugins__ there is a method __searchPlugins() which does not have a full documentation header and is unused, it appears to be complete but it is not used. It should be used instead because its functionality in initializing internal plugins is much faster and if there is an issue with plugins included at run-time it will not cause the lambda to fail.

Therefor:

  • Actually use it in the initializing constructor.
  • Finish documenting it.

The code was added on commit 6ec9a92 which was on February 28, so it has been sitting unfinished and unused for almost 7 months.

@XerTheSquirrel XerTheSquirrel added the bug Something that is not working correctly! label Sep 19, 2018
@XerTheSquirrel XerTheSquirrel added this to the Release 1.9.0 milestone Sep 19, 2018
@XerTheSquirrel XerTheSquirrel self-assigned this Sep 20, 2018
@XerTheSquirrel XerTheSquirrel added the review In review or needs reviewing label Sep 20, 2018
XerTheSquirrel added a commit that referenced this issue Sep 20, 2018
Fixes #177)

Finish the better plugin initialization code. (Fixes #177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is not working correctly! review In review or needs reviewing
Projects
None yet
Development

No branches or pull requests

1 participant