feat(alexaSkill): add alexaSkill event type #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for Alexa Intent, and Alexa Start/End Session event types. Adds idx dev dependency for terse yet performant event-type check fix iopipe#17
kolanos
reviewed
Apr 25, 2018
kolanos
previously approved these changes
Apr 25, 2018
ewindisch
reviewed
Apr 28, 2018
src/plugins/alexaSkill.js
Outdated
|
|
||
| function plugin(event, log) { | ||
| const obj = flatten(event); | ||
| Object.keys(obj).forEach(key => { |
There was a problem hiding this comment.
so we're logging all of the keys?
There was a problem hiding this comment.
It looks like keys we don't want capture (at least):
@iopipe/event-info.alexaSkill.context.System.apiAccessToken
@iopipe/event-info.alexaSkill.context.System.user.accessToken
@iopipe/event-info.alexaSkill.context.System.user.permissions.consentToken
There was a problem hiding this comment.
I can blacklist those, thanks @ewindisch makes it easy to update!
|
@ewindisch @kolanos back in review, added blacklisted keys requested by @ewindisch |
|
@coreylight @ewindisch Made equivalent updates here: iopipe/iopipe-python#218 |
kolanos
previously approved these changes
May 1, 2018
ewindisch
previously requested changes
May 3, 2018
Signed-off-by: Michael Lavers <kolanos@gmail.com>
kolanos
approved these changes
May 9, 2018
ewindisch
approved these changes
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idxdev dependency for terse yet performant event-type checkflatdep for capturing unanticipated object key/valuesfix #17