-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ios-deploy installing over both USB and WiFi #170
Comments
+1 |
1 similar comment
👍 |
Thanks for the report. Not sure how to debug this, I haven't seen this yet in my testing. Any particular command line flags? Do you mean during one deploy, it tries to deploy twice when two interfaces are detected for a device? |
Hi @shazron, here is a log for a simple |
Thank you! That helps a lot. |
Thinking out loud... I think the "Waiting for iOS device to be connected" phase was not terminated properly leading to this situation. Here we subscribe: https://github.com/phonegap/ios-deploy/blob/adc8a5b9c298d901d4388bb5cba20f9049b2dc83/ios-deploy.c#L1971 but there is no unsubscribe once a device connection was found. |
+1 I'm hitting this as well. Simply plugging in a device, turning on the WIFI and running
It deploys once over USB then again over WIFI. If I turn off WIFI then do it again, it didn't work, then I waited a minute and did it again and magically it worked. Is there some registry of devices it hears over WIFI that takes a bit of time to purge? Similarly, if I just quickly turn on my WIFI I don't hit this bug, but if my WIFI was on for a while then I hit it. |
Pushed a fix, will be out in v1.8.0. It's ugly but it'll do for now until a re-factor in v2.0 |
1.8.0 is out, please test and report if this is still a problem, thanks. |
@shazron hey there. I'm unfortunately still getting this problem with 1.8.0. Please help! Would it be possible to add a flag to simply completely turn off WiFi in ios-deploy as well? It would be a workaround while the bug itself is being diagnosed. |
@shazron When I turn off WiFi on the device, ios-deploy also apparently still thinks that the device is connected over WiFi, and tries to do the upload, but fails at AMDeviceValidatePairing(device) with a "This device is no longer connected." This causes ios-deploy to exit, and not launch the app that it has already installed over USB. Help appreciated. |
Good idea for the flag. The trouble is I can't repro this to fix this properly, and will have to rely on you to test. I'll put it in a branch for you to test, and report back. I'll add the flag |
I just pushed 1.8.1 with more verbose logging. Add |
@shazron I couldn't repro the issue after testing 1.8.1. I'm using --verbose though so if I see it again I'll have some logs for you. Re: --no-wifi - I couldn't find that branch. Am I too early? |
By the way, I think the 'installs over both usb and wifi' issue may be happening when I disconnect the device via USB, try to install w/o a USB connection (ios-deploy goes over wifi), and then reconnect and try installing again - it seems to install over both vectors. I'll have a log for you in a minute. |
Yes, it seems to install over USB first, and then install over wifi, but then fail to start to debug the app, as it is trying to do so over WiFi. |
@shazron Here's the log of me installing the app after having disconnected USB, trying to install (at which point it installs over wifi), and then reconnecting USB, and installing again. Note that it installs twice. |
@shazron Any way we might be able to expedite the --no-wifi flag? At the moment, this issue is occurring 100% of the time in most of my testing, and it thoroughly prevents ios-deploy from launching the app. |
+1 on this issue. |
Same here, the app is deployed over Wifi even though USB device is detected. When can we expect a fix for this? Log:
|
Hey @shazron did you get a chance to take a look at this? |
Hey all, just ran into this myself and submitted a fix in a pull request (#192) from my fork. Hope it helps someone. |
Also appear to be running into this problem. I can confirm turning off wifi on the device serves as a work-around. |
Merged #192 for 1.8.3 release (soon). |
1.8.3 published, give it a go. |
I was having a similar issue, but restarting the device fixed it. |
Unplugging the device from USB and plugging again solved for me. |
Even though the device is detected over USB and installation is initiated and completed over USB, after installation and entry into the debug phase, ios-deploy will detect the device over WIFI subsequently install the app over the air, even though it had just done so over USB. This also seems to step on any attempt to engage the debugger over USB. This only happens when WiFi is turned on, on the device. Seems like a bug that a duplicate install would happen. Specifying the device identifier with -i doesn't change the outcome. ios-deploy -c only lists one device, connected via USB.
The text was updated successfully, but these errors were encountered: