Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky tests #77

Open
nothingismagick opened this issue Mar 23, 2021 · 0 comments
Open

Flaky tests #77

nothingismagick opened this issue Mar 23, 2021 · 0 comments

Comments

@nothingismagick
Copy link
Contributor

nothingismagick commented Mar 23, 2021

Bug description

During a recent merge, we noticed that suddenly coverage went down in a part of the library that we hadn't touched. After some examination, we discovered that these two tests are flaky:

This test is flaky around 20% of the time:
test_wordlist_codec_error_detection

This one is flaky about 5% of the time:
test_wordlist_codec_different_data_different_encodings

To prove this, you can run:

$ while true; do; cargo test --features bip39,bip39-en,bip39-jp --test bip39; done

These two tests have something in common:

            OsRng.fill_bytes(&mut data);
            let ws = choose_wordlist();
            let ms = wordlist::encode(&data, ws).unwrap();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant