implement http 400 bad request #1119
Conversation
howjmay
requested review from
oopsmonk,
thibault-martinez and
tsvisabo
as code owners
|
Sorry for the delay, I had to think about this one. Will review later today ! |
ciri/api/http/http.c
Outdated
| retcode_t ret = RC_OK; | ||
|
|
||
| if (*error == NULL) { | ||
| if (message == NULL) { | ||
| if (message == NULL && status_code == MHD_HTTP_INTERNAL_SERVER_ERROR) { |
There was a problem hiding this comment.
I originally thought I should use Bad request as dfault error status code.
I will change && to ||
There was a problem hiding this comment.
I don't think it's necessary at all
There was a problem hiding this comment.
Remove && status_code == MHD_HTTP_INTERNAL_SERVER_ERROR
| retcode_t ret = RC_OK; | ||
|
|
||
| if (*error == NULL) { | ||
| if (message == NULL) { | ||
| if (message == NULL && status_code == MHD_HTTP_INTERNAL_SERVER_ERROR) { | ||
| *error = error_res_new("Internal server error"); |
There was a problem hiding this comment.
Can you add status_code as parameter to error_res_new ?
|
Since you opened this PR, I started working on a gRPC API. |
got it! cheer up |
|
Won't be merged due to ciri being discontinued and entangled soon being archived. |
Add arg
status_codetoerror_serialize_response()Return status code 400 if no message and no status code was specified.
fixes #1085