Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

ciri: ledger validator fixes and improvements #577

Merged
merged 11 commits into from
Dec 4, 2018
Merged

ciri: ledger validator fixes and improvements #577

merged 11 commits into from
Dec 4, 2018

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Nov 29, 2018 •
edited
Loading

  • Fixes ledger validator inconsistency errors
  • Drastically improves update_snapshot perfs
  • Removes useless database fetching
  • Fixes a bug in loading bundles from bundle validator
  • Removes a huge leak
  • Fixes a tangle traversal issue that prevented branches from being analysed
  • Checks solidity of entry points - Fixes ledger_validator: only process solid transactions #511
  • Cleans and nits

Test Plan:

CI must pass.

@thibault-martinez thibault-martinez added the A-ciri Area - cIRI label Nov 29, 2018
@th0br0 th0br0 mentioned this pull request Nov 29, 2018
Closed
@thibault-martinez thibault-martinez changed the title ciri: fix ledger inconsistency ciri: ledger validator fixes and improvements Nov 30, 2018
@thibault-martinez thibault-martinez added S-waiting-on-author Status - Waiting on author S-do-not-merge Status - DO NOT MERGE labels Dec 2, 2018
@tsvisabo tsvisabo merged commit 0d83b50 into iotaledger:develop Dec 4, 2018
@thibault-martinez thibault-martinez deleted the ciri-fix-ledger-inconsistency branch December 4, 2018 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tsvisabo tsvisabo tsvisabo approved these changes

@th0br0 th0br0 Awaiting requested review from th0br0

Assignees
No one assigned
Labels
A-ciri Area - cIRI S-do-not-merge Status - DO NOT MERGE S-waiting-on-author Status - Waiting on author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thibault-martinez @tsvisabo