Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM support #1241

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add ARM support #1241

wants to merge 2 commits into from

Conversation

Dr-Electron
Copy link
Contributor

Description of change

This PR adds support for ARM. Currently it still doesn't work, because there is not ARM support for the SDK it seams.

Links to any relevant issues

Fixes iotaledger/iota-sandbox#28.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@msarcev
Copy link
Collaborator

msarcev commented Apr 17, 2024

 => CACHED [3/8] WORKDIR /usr/src/app                                                                                                                                                                        0.0s
 => CACHED [4/8] COPY . ./                                                                                                                                                                                   0.0s
 => ERROR [5/8] RUN npm install --maxsockets 1                                                                                                                                                             108.0s
------
 > [5/8] RUN npm install --maxsockets 1:
11.20 npm WARN deprecated text-encoding@0.7.0: no longer maintained
17.26 npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
107.5 npm notice
107.5 npm notice New major version of npm available! 8.19.4 -> 10.5.2
107.5 npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
107.5 npm notice Run `npm install -g npm@10.5.2` to update!
107.5 npm notice
107.5 npm ERR! code 1
107.5 npm ERR! path /usr/src/app/node_modules/@iota/sdk
107.5 npm ERR! command failed
107.5 npm ERR! command sh -c -- prebuild-install --runtime napi --tag-prefix=iota-sdk-nodejs-v && tsc || npm run rebuild
107.5 npm ERR! > @iota/sdk@1.1.5 rebuild
107.5 npm ERR! > node scripts/neon-build && tsc && node scripts/strip.js
107.5 npm ERR!
107.5 npm ERR! yarn run v1.22.19
107.5 npm ERR! $ cargo-cp-artifact -ac iota-sdk-nodejs ./index.node -- cargo build --profile=production --message-format=json-render-diagnostics
107.5 npm ERR! info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
107.5 npm ERR! prebuild-install warn install No prebuilt binaries found (target=6 runtime=napi arch=arm64 libc= platform=linux)
107.5 npm ERR! Error: could not find the `cargo` executable.

Seams like there are no prebuilt binaries linux/arm64 🤔 ?

@Dr-Electron
Copy link
Contributor Author

Correct. iotaledger/iota-sdk#97

@andy-uphold
Copy link

andy-uphold commented Aug 5, 2024

nor x64?

[5/5] Building fresh packages...
error /__w/[redacted]/node_modules/@iota/sdk: Command failed.
Exit code: 1
Command: prebuild-install --runtime napi --tag-prefix=iota-sdk-nodejs-v && tsc || npm run rebuild
Arguments: 
Directory: /__w/[redacted]/node_modules/@iota/sdk
Output:
prebuild-install warn install No prebuilt binaries found (target=6 runtime=napi arch=x64 libc=musl platform=linux)

And including cargo so it can be built results in this:

error: cannot produce cdylib for `iota-sdk-nodejs v0.1.0 (/__w/t[redacted]/node_modules/@iota/sdk)` as the target `x86_64-unknown-linux-musl` does not support these crate types

@andy-uphold
Copy link

hello? anyone care about this PR? See comment above

@Dr-Electron
Copy link
Contributor Author

The SDK is blocking this issue. Why do you try to build the explorer from scratch? We have a docker image for it. If you need further help please ask on our discord

@andy-uphold
Copy link

I'm not building the explorer, I'm doing something similar with the SDK and running into the same issues. I'll bring this up on Discord. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing Apple M1 support
3 participants