-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support arm64 architectures for the nodeJS bindings #97
Comments
Similar work was done for Java here: https://github.com/iotaledger/wallet.rs/blob/develop/.github/workflows/java_binding_publish.yml Since GitHub Actions does not have arm64-based Mac runners, we'll have to cross-compile on the x64 runners. I also wonder if setting the macOS deployment target to 10.12 will pose any issues here 🤔 If necessary we can simply move that to only be set when building for x64 |
We reverted the change, since it wasn't building properly on M1 chips: iotaledger/wallet.rs#1779 |
For macos I got it working now, ubuntu and windows still have errors:
windows:
|
The
Maybe the target arch is not passed correctly?
|
Macos arm64 has been addressed. Linux and windows will be done at a later stage as to not block the release. Moving it to the 1.1 milestone. |
Any progress on this? I'm having linux issues. |
Still having issues. Anyone working on this? |
Description
We are missing binaries that support the arm64 architecture
Motivation
prebuild
only builds binaries targetting the x64 architecture. Since a lot of users use arm64, we need to update the workflows to include builds for arm64 as well.Are you planning to do it yourself in a pull request?
Yes
The text was updated successfully, but these errors were encountered: