Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create arm64 builds #1751

Merged
merged 1 commit into from
Jan 24, 2023
Merged

feat: create arm64 builds #1751

merged 1 commit into from
Jan 24, 2023

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Jan 24, 2023

Description of change

Creates arm64 builds for windows/mac/linux.

Links to any relevant issues

closes: iotaledger/iota-sdk#97

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Cross-compiled the binaries locally by running the following commands:

npm run prebuild-x64
npm run prebuild-arm64

The prebuilds should appear in the bindings/nodejs/prebuilds/@iota folder

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Tuditi Tuditi self-assigned this Jan 24, 2023
@Tuditi Tuditi merged commit 049780d into develop Jan 24, 2023
@Tuditi Tuditi deleted the feat/create-arm64-builds branch January 24, 2023 15:54
amadeu2 added a commit to amadeu2/wallet.rs that referenced this pull request Jan 26, 2023
* develop: (70 commits)
  Feat: rocksdb as optional storage (iotaledger#1728)
  apply version updates (iotaledger#1755)
  Make the voting output mandatory in input selection for voting functions (iotaledger#1753)
  fix: tag-prefix passed as a string (iotaledger#1752)
  apply version updates (iotaledger#1750)
  Use OutputMetadataDto (iotaledger#1749)
  feat: create arm64 builds (iotaledger#1751)
  Allow voting output in inputs if required (iotaledger#1748)
  apply version updates (iotaledger#1745)
  Use new Input Selection (iotaledger#1744)
  Fix dependabot audit (iotaledger#1747)
  Add Python integration guide with IOTA and Shimmer (iotaledger#1743)
  Change sync options (iotaledger#1737)
  Add inputs to transaction to align incoming transactions (iotaledger#1722)
  apply version updates (iotaledger#1729)
  Send requests in parallel, check participation output unlock conditions (iotaledger#1740)
  Move all participation methods from the AccountManager to the Account (iotaledger#1736)
  Limit max parallel request in request_incoming_transaction_data() (iotaledger#1720)
  Remove useless old code (iotaledger#1731)
  chore: add more alignment for participation code (iotaledger#1727)
  ...

Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Tuditi added a commit that referenced this pull request Jan 30, 2023
Tuditi added a commit that referenced this pull request Jan 30, 2023
* Revert "fix: manually download windows arm64 build (#1757)"

This reverts commit 2b55fad.

* Revert "feat: create arm64 builds (#1751)"

This reverts commit 049780d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support arm64 architectures for the nodeJS bindings
3 participants