Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Add security_level parameter to get_inputs, prepare_transfer and send_transfer #172

Closed
lunfardo314 opened this issue Mar 30, 2018 · 5 comments

Comments

@lunfardo314
Copy link

is there a reason why get_inputs always uses default security level to generate addresses? Maybe it makes sense to add parameter security_level for the sake of consistency? otherwise get_inputs is useless for security_level 1 and 3 .

@todofixthis
Copy link
Contributor

todofixthis commented Mar 30, 2018

Hey @lunfardo314 good catch; thanks for raising this issue!

That does look like an oversight; I agree that it makes sense to make security level configurable.

Hm. I addition to get_inputs, we should probably also add a parameter to prepare_transfer and send_transfer (would configure generation of input addresses and change address).

@todofixthis todofixthis changed the title security_level for get_inputs Add security_level parameter to get_inputs, prepare_transfer and send_transfer Mar 30, 2018
@lunfardo314
Copy link
Author

I created pull request for this issue, don't know how to reference it here

@todofixthis
Copy link
Contributor

Thanks for your pull request! Check this out for how to reference stuff:
https://help.github.com/articles/autolinked-references-and-urls/

@lunfardo314
Copy link
Author

so I do it this way: #173 ! Great, thanks!

@todofixthis
Copy link
Contributor

Scheduled for release: v2.0.6

Thanks @lunfardo314 !!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants