This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
Test: Updated TransactionTestUtils, its usage, and javadoc #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwek20
changed the title
6 tasks
karimodm
suggested changes
Mar 5, 2019
| @@ -91,7 +91,7 @@ public void requestTransaction(Hash hash, boolean milestone) throws Exception { | |||
| * | |||
| * It used when the queue capacity is reached, and new transactions would be dropped as a result. | |||
| */ | |||
| // @VisibleForTesting | |||
| //Package Private For Testing | |||
There was a problem hiding this comment.
default method visibility: package level.
There was a problem hiding this comment.
@karimodm What do you mean? If you're talking about the message, pretty sure @GalRogozinski told me to name it like this.
There was a problem hiding this comment.
Ah talked with Gal, were going with the annotation now!
src/main/java/com/iota/iri/controllers/TransactionViewModel.java
Outdated
Show resolved
Hide resolved
|
Looks good, but some more fixes might be good since we are at it. |
kwek20
force-pushed
the
test-util-changes
branch
from
208896e
to
f58d6f9
Compare
karimodm
approved these changes
Apr 2, 2019
6 tasks
GalRogozinski
suggested changes
Apr 28, 2019
GalRogozinski
approved these changes
May 5, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to unit tests required for the added unit tests in #1091
Type of change
Checklist: