-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inputs to transaction to align incoming transactions #1722
Merged
thibault-martinez
merged 8 commits into
iotaledger:develop
from
Thoralf-M:add-inputs-to-transactions
Jan 20, 2023
Merged
Add inputs to transaction to align incoming transactions #1722
thibault-martinez
merged 8 commits into
iotaledger:develop
from
Thoralf-M:add-inputs-to-transactions
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1e4517
to
dc0d89f
Compare
a5e5641
to
ee62759
Compare
samuel-rufi
previously approved these changes
Jan 16, 2023
ee62759
to
58d1737
Compare
thibault-martinez
requested changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicting
Co-authored-by: Thibault Martinez <thibault.martinez.30@gmail.com>
58d1737
to
dee2d74
Compare
thibault-martinez
previously approved these changes
Jan 20, 2023
kwek20
previously approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides those tests its 👌 but i can add those as well
520b6aa
thibault-martinez
approved these changes
Jan 20, 2023
kwek20
approved these changes
Jan 20, 2023
amadeu2
added a commit
to amadeu2/wallet.rs
that referenced
this pull request
Jan 26, 2023
* develop: (70 commits) Feat: rocksdb as optional storage (iotaledger#1728) apply version updates (iotaledger#1755) Make the voting output mandatory in input selection for voting functions (iotaledger#1753) fix: tag-prefix passed as a string (iotaledger#1752) apply version updates (iotaledger#1750) Use OutputMetadataDto (iotaledger#1749) feat: create arm64 builds (iotaledger#1751) Allow voting output in inputs if required (iotaledger#1748) apply version updates (iotaledger#1745) Use new Input Selection (iotaledger#1744) Fix dependabot audit (iotaledger#1747) Add Python integration guide with IOTA and Shimmer (iotaledger#1743) Change sync options (iotaledger#1737) Add inputs to transaction to align incoming transactions (iotaledger#1722) apply version updates (iotaledger#1729) Send requests in parallel, check participation output unlock conditions (iotaledger#1740) Move all participation methods from the AccountManager to the Account (iotaledger#1736) Limit max parallel request in request_incoming_transaction_data() (iotaledger#1720) Remove useless old code (iotaledger#1731) chore: add more alignment for participation code (iotaledger#1727) ... Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add inputs to transaction and use the same type for incoming transactions
Links to any relevant issues
Fixes #1648
Type of change
How the change has been tested
Running a modified nodejs example which also syncs incoming transactions
Change checklist