Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inputs to transaction to align incoming transactions #1722

Merged

Conversation

Thoralf-M
Copy link
Member

Description of change

Add inputs to transaction and use the same type for incoming transactions

Links to any relevant issues

Fixes #1648

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Running a modified nodejs example which also syncs incoming transactions

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Thoralf-M Thoralf-M force-pushed the add-inputs-to-transactions branch 4 times, most recently from f1e4517 to dc0d89f Compare January 14, 2023 18:04
@Thoralf-M Thoralf-M marked this pull request as ready for review January 14, 2023 18:16
CHANGELOG.md Outdated Show resolved Hide resolved
samuel-rufi
samuel-rufi previously approved these changes Jan 16, 2023
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicting

kwek20
kwek20 previously approved these changes Jan 20, 2023
Copy link
Contributor

@kwek20 kwek20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides those tests its 👌 but i can add those as well

tests/account_deserialization.rs Show resolved Hide resolved
@thibault-martinez thibault-martinez merged commit b74768e into iotaledger:develop Jan 20, 2023
@Thoralf-M Thoralf-M deleted the add-inputs-to-transactions branch January 20, 2023 16:49
amadeu2 added a commit to amadeu2/wallet.rs that referenced this pull request Jan 26, 2023
* develop: (70 commits)
  Feat: rocksdb as optional storage (iotaledger#1728)
  apply version updates (iotaledger#1755)
  Make the voting output mandatory in input selection for voting functions (iotaledger#1753)
  fix: tag-prefix passed as a string (iotaledger#1752)
  apply version updates (iotaledger#1750)
  Use OutputMetadataDto (iotaledger#1749)
  feat: create arm64 builds (iotaledger#1751)
  Allow voting output in inputs if required (iotaledger#1748)
  apply version updates (iotaledger#1745)
  Use new Input Selection (iotaledger#1744)
  Fix dependabot audit (iotaledger#1747)
  Add Python integration guide with IOTA and Shimmer (iotaledger#1743)
  Change sync options (iotaledger#1737)
  Add inputs to transaction to align incoming transactions (iotaledger#1722)
  apply version updates (iotaledger#1729)
  Send requests in parallel, check participation output unlock conditions (iotaledger#1740)
  Move all participation methods from the AccountManager to the Account (iotaledger#1736)
  Limit max parallel request in request_incoming_transaction_data() (iotaledger#1720)
  Remove useless old code (iotaledger#1731)
  chore: add more alignment for participation code (iotaledger#1727)
  ...

Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align transaction and incoming transactions objects
4 participants