Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing Linter Suggestions from 'make lint' Command Execution #3409

Open
Ginowine opened this issue May 21, 2024 · 0 comments
Open

Addressing Linter Suggestions from 'make lint' Command Execution #3409

Ginowine opened this issue May 21, 2024 · 0 comments

Comments

@Ginowine
Copy link
Contributor

After following the steps outlined in the CONTRIBUTING.md file and executing the 'make lint' command, the following linter suggestions are generated:

cli/wallet/wallet.go:48:9: do not define dynamic errors, use wrapped static errors instead: "errors.New(\"invalid wallet provider provided\")" (err113)
        return errors.New("invalid wallet provider provided")
               ^
cli/keychain/keychain_file.go:57:11: G306: Expect WriteFile permissions to be 0600 or less (gosec)
                neErr = os.WriteFile(k.FilePath(), result, os.ModePerm)
                        ^
cli/keychain/keychain_file.go:132:8: G306: Expect WriteFile permissions to be 0600 or less (gosec)
        err = os.WriteFile(k.FilePath(), payload, os.ModePerm)
              ^
cli/config/config.go:209:9: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"target network of the L1 node does not match the wasp-cli config\")" (err113)
                err = fmt.Errorf("target network of the L1 node does not match the wasp-cli config")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant