-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ed25519 HD keyring #24
Comments
These may be useful links: |
I've used https://github.com/bitcoinjs/bip39 before: solid with some multi-language support. |
Builds upon #52 |
Could you elaborate what you mean by that @ethanfrey? What use case do you have in mind here? Right now we have no concept of verifying other people's signatures in a Keyring |
At one point, I thought we would expose verify in a keyring, but this is done in I guess you are just using the Slip0010 class to create a private key to feed into the above class, so of course the signatures should verify with the same class. I guess a proper rewording would just be: "Verify that you can generate a key in this KeyRing, properly sign a message, and verify the signature with Does that work? If so, I will update the issue text. |
Thanks for clarification, this makes sense. Given that Slip0010 outputs private keys only, the rest is done using |
Status: the heavy work is done. Just the proper derivation paths are missing |
Yeah, looks like 95% done, just a bit of polish. |
Like #23, except instead of generating a random key each time, we generate a unique seed on initialization, which we expose as a bip39 mneumonic. We then use a bip32 hd key derivation to generate a sequence of keys, based on a path that can be provided in the constructor.
We can generate new keys from this seed at will, and we can sign with any of them.
Please verify that you can generate a key in this KeyRing, properly sign a message, and verify the signature with @iov/crypto:Ed25519 using the public key returned from the keyring. This serves mainly as an example of normal usage of the HD Keyring, as well as a sanity check.
The text was updated successfully, but these errors were encountered: