add ignore flag #80
Merged
add ignore flag #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is to propagate these changes to bov. |
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
========================================
+ Coverage 77.6% 78.1% +0.4%
========================================
Files 56 56
Lines 2449 2398 -51
========================================
- Hits 1902 1874 -28
+ Misses 444 425 -19
+ Partials 103 99 -4
Continue to review full report at Codecov.
|
alpe
approved these changes
Jun 27, 2018
ethanfrey
approved these changes
Jun 27, 2018
| @@ -33,14 +34,16 @@ Usage: | |||
| xxx init -all=f // no index | |||
| xxx init -tags=foo,bar // index only foo and bar | |||
| */ | |||
| func parseIndex(args []string) (bool, bool, string, []string, error) { | |||
| func parseIndex(args []string) (bool, bool, string, bool, []string, error) { | |||
There was a problem hiding this comment.
As the number of return values go, let's consider returning a struct with named fields, eg.
type flags struct {
indexAll bool
force bool
tags string
ignore bool
args []string
}
or maybe keep args separate, but at least the flags together
| // parse flagIndexAll, flagIndexTags and return the result | ||
| indexFlags := flag.NewFlagSet("init", flag.ExitOnError) | ||
| tags := indexFlags.String(flagIndexTags, "", "comma-separated list of tags to index") | ||
| all := indexFlags.Bool(flagIndexAll, true, "") | ||
| force := indexFlags.Bool(FlagForce, false, "") | ||
| ignore := indexFlags.Bool(FlagIgnore, false, "") |
There was a problem hiding this comment.
Maybe add an explanation here?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a quick fix needed to sort pod restarts