Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Raise max llvm major version to 16 #2528

Closed
wants to merge 0 commits into from
Closed

Conversation

kraj
Copy link
Contributor

@kraj kraj commented Mar 14, 2023

No description provided.

@viktormalik
Copy link
Contributor

Could we add LLVM 16 to the CI?

@kraj
Copy link
Contributor Author

kraj commented Mar 15, 2023

Could we add LLVM 16 to the CI?

Once it releases then yes, it is in RC4 right now. Perhaps final release will happen any time

@viktormalik
Copy link
Contributor

Could we add LLVM 16 to the CI?

Once it releases then yes, it is in RC4 right now. Perhaps final release will happen any time

Ok, thanks for the info. I'd prefer waiting until that happens. I don't fancy the idea of having support for something that isn't properly tested.

@danobi
Copy link
Member

danobi commented Mar 19, 2023

I believe llvm 16 is released now

@viktormalik
Copy link
Contributor

@kraj please add LLVM 16 to the CI as a part of this PR.

@kraj
Copy link
Contributor Author

kraj commented Mar 28, 2023

@kraj please add LLVM 16 to the CI as a part of this PR.

Sadly, we are running into llvm/llvm-project#61436 which will be fixed in 16.0.1 point release hopefully, since the fix is already attached to the issue. Until then clang-16 loop wont be able to run.

@viktormalik
Copy link
Contributor

@kraj please add LLVM 16 to the CI as a part of this PR.

Sadly, we are running into llvm/llvm-project#61436 which will be fixed in 16.0.1 point release hopefully, since the fix is already attached to the issue. Until then clang-16 loop wont be able to run.

Ok, hopefully they release it soon. I suggest to wait until then.

@juchem
Copy link

juchem commented Mar 31, 2023

@kraj @viktormalik I'd appreciate if you folks could bump that LLVM issue, since there's not a lot of activity from the LLVM folks to help get it merged.

@viktormalik
Copy link
Contributor

16.0.1 has been out for two weeks but the issue doesn't seem to be fixed (at least restarting the CI didn't help)

@viktormalik viktormalik added this to the 0.18 milestone Apr 20, 2023
@viktormalik
Copy link
Contributor

We should try our best to have this in the 0.18 release (currently planned for May 1st).

@danobi
Copy link
Member

danobi commented May 9, 2023

While upstream LLVM should still be fixed, we can work around the bug by doing something like bcc does:

iovisor/bcc@a1525b7

@viktormalik
Copy link
Contributor

While upstream LLVM should still be fixed, we can work around the bug by doing something like bcc does:

iovisor/bcc@a1525b7

Sounds good. Let me give it a try so that we can do a release with LLVM 16 support.

@viktormalik viktormalik self-assigned this May 10, 2023
@viktormalik
Copy link
Contributor

Ok, I have it ready and it passes the CI. @kraj do you mind if I push it directly to this PR (which would be your master branch) or should I open a new one?

@kraj
Copy link
Contributor Author

kraj commented May 10, 2023

Ok, I have it ready and it passes the CI. @kraj do you mind if I push it directly to this PR (which would be your master branch) or should I open a new one?

please go ahead.

@viktormalik
Copy link
Contributor

Looks like it's not possible (protected master branch?) so I opened a new PR #2592. Feel free to review, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants