Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bpftracebase): bump bpftrace base to 81b099f094d2e6092cfe1317cbaaba0c1bbb614f and bcc 0.8.0 #66

Merged

Conversation

fntlnz
Copy link
Member

@fntlnz fntlnz commented Mar 8, 2019

  • Updated bpftrace to 81b099f094d2e6092cfe1317cbaaba0c1bbb614f
  • Updated bcc to 0.8.0
    Signed-off-by: Lorenzo Fontana lo@linux.com

…aaba0c1bbb614f and bcc 0.8.0

Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz
Copy link
Member Author

fntlnz commented Mar 8, 2019

@dalehamel PTAL, I just updated the bpftrace to include your latest changes.

@dalehamel
Copy link
Member

LGTM, though I want to point out that I'm a bit concerned about the use of a static executable in general, per #51, bpftrace/bpftrace#266, and bpftrace/bpftrace#342

Using the static bpftrace, some scripts will deterministically crash, which really limits the usefulness of kubectl-trace. For instance, not even all of the default scripts included with bpftrace will work :(

I had a PR up #52 that offers an alternative using ubuntu and a dynamic build (using glibc), but it results in a much larger image.

I'll bring this up in slack for a broader discussion on it

@leodido
Copy link
Member

leodido commented Mar 9, 2019

As discussed privately, we could consider to ship both the images (static and dynamic) letting the user choose whether to use one or the other via flags.

@leodido leodido self-requested a review March 9, 2019 21:30
@dalehamel
Copy link
Member

As part of #52 i bumped to v0.9, and the static build is broken upstream. I had to make a number of changes and still haven't gotten it working for static.

@fntlnz fntlnz merged commit fe9b466 into master Apr 1, 2019
@fntlnz fntlnz deleted the feat/bump-bpftrace-81b099f094d2e6092cfe1317cbaaba0c1bbb614f branch April 1, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants