Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uBPF uses 128 byte stack by default - Should this match the common consensus of 512 bytes #74

Closed
Alan-Jowett opened this issue May 20, 2021 · 2 comments · Fixed by #75
Closed

uBPF uses 128 byte stack by default - Should this match the common consensus of 512 bytes #74

Alan-Jowett opened this issue May 20, 2021 · 2 comments · Fixed by #75

Comments

@Alan-Jowett
Copy link
Collaborator

uBPF uses 128 byte stack by default - Should this match the common consensus of 512 bytes?

Other projects (Linux, generic-epbf and others) all agree on a 512 byte stack size. Anyone know why uBPF has a default of 512?
@rlane
Copy link
Collaborator

rlane commented May 24, 2021

Feel free to change the default to 512. I don't recall any specific reason for choosing 128.

@niclashedam niclashedam mentioned this issue May 24, 2021
Merged
@niclashedam
Copy link

I agree on this. I have gone ahead and created a PR for this (#75).

@rlane rlane closed this as completed in #75 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increasing stack size to common consensus of 512
3 participants
@rlane @niclashedam @Alan-Jowett