Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTP GET request for acquiring family information #34

Closed
wants to merge 1 commit into from
Closed

Use HTTP GET request for acquiring family information #34

wants to merge 1 commit into from

Conversation

amotl
Copy link
Member

@amotl amotl commented Oct 1, 2019

Dear George,

we've outlined the background for this update at #33 and humbly ask you to create a patch release if this resonates with you.

Thanks already and with kind regards,
Andreas.

@amotl amotl changed the title Use HTTP GET request for acquiring family information. Fix #33. Use HTTP GET request for acquiring family information Oct 1, 2019
@amotl
Copy link
Member Author

amotl commented Oct 22, 2019

Dear @gsong,

this update is rather important to the PatZilla and Patent2Net communities.

The updated functionality is secured by additional unit tests, so we are pretty sure things won't go south.

So, we are humbly asking if you could review the update and make a release on PyPI. Thank you so much for taking the time!

With kind regards,
Andreas.

@gsong
Copy link
Member

gsong commented Oct 23, 2019

@amotl Arg, why doesn't GitHub send me notifications when a PR is opened!? I'll take a look at this shortly and provide feedback or release.

@amotl
Copy link
Member Author

amotl commented Oct 23, 2019

@gsong: Excellent, thanks!

@gsong gsong force-pushed the development branch 5 times, most recently from 6542496 to b773374 Compare October 27, 2019 22:05
@gsong
Copy link
Member

gsong commented Oct 28, 2019

@amotl I'm working through the conflicts (simple) and some refactoring right now, so don't worry about pushing additional code to this branch. I'll let you know as soon as the next version is released with this feature (should be today or tomorrow).

@amotl
Copy link
Member Author

amotl commented Oct 28, 2019

Dear @gsong,

thanks a bunch for working on the update, I recognize what you are doing there.

The commit today was just a slight update for the family-legal test where I spotted a typo as it would redundantly run the family-biblio test I added for covering the regression.

Thanks again!

Cheers,
Andreas.

@gsong
Copy link
Member

gsong commented Oct 28, 2019

@amotl Can you take a look at https://github.com/55minutes/python-epo-ops-client/tree/ip-tools-fix-family to make sure your fix made it in? I'm not sure exactly what you changed.

@amotl
Copy link
Member Author

amotl commented Oct 28, 2019

I can confirm the little fix I made before is in [1] already, thanks!

[1] https://github.com/55minutes/python-epo-ops-client/blob/ip-tools-fix-family/tests/test_api.py#L37-L42

@gsong
Copy link
Member

gsong commented Oct 28, 2019

👍

@gsong
Copy link
Member

gsong commented Oct 28, 2019

@amotl This has been released: https://pypi.org/project/python-epo-ops-client/

@gsong gsong closed this Oct 28, 2019
@amotl
Copy link
Member Author

amotl commented Oct 29, 2019

Thank you so much [1] and keep up the good work!

[1] https://meta.ip-tools.org/t/bibliographic-data-missing-from-ops-family-response/161/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants