7z t giving wrong information about integrity of archive when quitting scanning archive

[artsi0m]

How to reproduce:

1. Create archive with 7z a archive-path.7z -mx=9 dir-to-archive
2. Wait till it will be properly archived
3. Try to verify integrity of archive with 7z t archieve.7z
4. Accidentally type Ctrl-C in terminal terminating the process of verifying.
5. Receive information about archive being corrupted and be sad.
6. Mind that you terminated the process and try again with 7z t archive.7z till it properly ends saying everything is ok. Be a little be confused.

Reproduced with 7-Zip 24.07 (x64) on Windows 11

What could be changed so, error message would state something like
Integrity check was interrupted by signal, proper information is not available?

Should it be done in a first place, because it already writes Break signaled with the last line of message after typing ctrl-c ?

[ip7z]

Please show full log after Ctrl+C.
Also create another archive that contains only one big tar file and show log after Ctrl+C.

[artsi0m]

Full log after Ctrl+C

artsi0m@Kanamori:~> 7z t /run/media/artsi0m/6E3E04E33E04A665/Documents.7z

7-Zip (z) 24.07 (x64) : Copyright (c) 1999-2024 Igor Pavlov : 2024-06-19
 64-bit locale=C.UTF-8 Threads:8 OPEN_MAX:1024, ASM

Scanning the drive for archives:
1 file, 8149062566 bytes (7772 MiB)

Testing archive: /run/media/artsi0m/6E3E04E33E04A665/Documents.7z
--
Path = /run/media/artsi0m/6E3E04E33E04A665/Documents.7z
Type = 7z
Physical Size = 8149062566
Headers Size = 204950
Method = ARM64 LZMA2:26 LZMA:20 BCJ2
Solid = +
Blocks = 3

 3
Archives with Errors: 1



Break signaled
artsi0m@Kanamori:~>

(I am doing it on another OS though)

[ip7z]

It doesn't write that archive is currupted.
But it counts break signal as some type of error (error during archive processing).
I suppose that issue is not critical.

[artsi0m]

I suppose that issue is not critical.

So, changing the error message is not needed ?

[ip7z]

I'll try to remove "Archives with Errors: *" message for that case.

[artsi0m]

Maybe If it is not high priority issue and I was the first one who reported it you could tell me what should be done to remove that message, so I will try to do this and show you a patch for reviewing ?

[ip7z]

I've fixed it:

ExtractCallbackConsole.cpp:

  else
  {
    // we don't update NumArcsWithError, if error is not related to archive data.
    if (result == E_ABORT
        || result == HRESULT_FROM_WIN32(ERROR_DISK_FULL))
      return result;
    NumArcsWithError++; 
    
    if (_se)
    {
      *_se << endl << kError;
      if (result == E_OUTOFMEMORY)

[artsi0m]

Thanks a lot!