Multi distro travis #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmessmer
force-pushed
the
multi_distro_travis
branch
from
ed7a7f1
to
0abfa17
Compare
|
remove cob4-10 after ipa320/cob_robots#634 |
mgruhler
suggested changes
Mar 20, 2017
| endforeach(robot) | ||
| find_package(cob_supported_robots REQUIRED) | ||
| find_package(cob_default_env_config REQUIRED) | ||
| find_package(roslaunch REQUIRED) |
There was a problem hiding this comment.
why do you find_package all those packages directly and not via catkin?
There was a problem hiding this comment.
because they are test_depends
| find_package(cob_default_env_config REQUIRED) | ||
| find_package(roslaunch REQUIRED) | ||
| foreach(robot ${cob_supported_robots_ROBOTLIST}) | ||
| foreach(env ${cob_default_env_config_ENVLIST}) |
There was a problem hiding this comment.
hmm, probably because of those lists? Can't you access them this way if you find them via catkin? But then, what about roslaunch?
mgruhler
approved these changes
Mar 20, 2017
ipa-nhg
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes #79
no kinetic_dev needed