Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Buffer Size in /people Topic #52

Closed
RoboEvangelist opened this issue Nov 17, 2016 · 4 comments
Closed

Infinite Buffer Size in /people Topic #52

RoboEvangelist opened this issue Nov 17, 2016 · 4 comments
Assignees

Comments

@RoboEvangelist
Copy link

RoboEvangelist commented Nov 17, 2016

Folks,

Check in line 192 of cob_people_perception/cob_openni2_tracker/ros/src/body_tracker.cpp where the buffer size is Zero (infinite size). It should be at least 1, as this can cause issue when there is a lot of subscribers for this topic.

@floweisshardt
Copy link
Member

@ipa-rmb: please check

ipa-rmb added a commit that referenced this issue Nov 21, 2016
according to suggestion in issue #52
@ipa-rmb
Copy link
Contributor

ipa-rmb commented Nov 21, 2016

Thanks for your suggestion. I adapted the code accordingly. Thanks for helping us to improve this software.

Just for curiosity, could you tell us whether you had concrete problems with the infinite queue in the body_tracker.cpp or with some other software? What kind of problems did it cause?

@RoboEvangelist
Copy link
Author

I just noticed that when I have many nodes subscribing to the /people topic and running for a very long time (72 continues hours tracking a dummy skeleton), then the program would crash eventually. Then I changed the queue size, and the program has not been crashing under the same conditions. Since I have not seen the same error, then I assumed queue size has something to do with it. But I don't have concrete proof, though. What I do know is that if queue size is 0, then memory size can increase indefinitely.

@ipa-rmb
Copy link
Contributor

ipa-rmb commented Dec 20, 2016

Thanks for your sharing your experiences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants