This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
test: add CID version agnostic tests #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
ghost
assigned 
2 tasks
alanshaw
added a commit
to ipfs-inactive/js-ipfs-http-client
that referenced
this pull request
Dec 9, 2018
The CID version agnostic tests ipfs-inactive/interface-js-ipfs-core#413 identified some functions were not properly serializing CID instances. This PR adds `cleanCID` step to several functions and also updates the `cleanCID` function to not assume buffer CIDs are CIDv0 multihashes. depends on ipfs-inactive/interface-js-ipfs-core#413 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
1 task
daviddias
reviewed
Dec 11, 2018
js/src/block/get.js
Outdated
| @@ -4,6 +4,7 @@ | |||
| const multihash = require('multihashes') | |||
| const CID = require('cids') | |||
| const auto = require('async/auto') | |||
| const crypto = require('crypto') | |||
There was a problem hiding this comment.
Do the bytes need to be so random that it requires to add the crypto module (and respective browser polyfill?)
There was a problem hiding this comment.
No, and it's probably faster to just use Date.now() or Math.random(). I've removed all instances of crypto. There's one test that generates lots of random data to ensure it spans multiple dag nodes and I've changed that test to use randombytes so we don't pull in the whole of crypto in the browser.
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
|
Assuming this PR is gtg now @daviddias - please shout if you have further changes and I'll submit another PR! |
alanshaw
added a commit
to ipfs-inactive/js-ipfs-http-client
that referenced
this pull request
Dec 12, 2018
The CID version agnostic tests ipfs-inactive/interface-js-ipfs-core#413 identified some functions were not properly serializing CID instances. This PR adds `cleanCID` step to several functions and also updates the `cleanCID` function to not assume buffer CIDs are CIDv0 multihashes. depends on ipfs-inactive/interface-js-ipfs-core#413 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
added a commit
to ipfs-inactive/js-ipfs-http-client
that referenced
this pull request
Dec 13, 2018
The CID version agnostic tests ipfs-inactive/interface-js-ipfs-core#413 identified some functions were not properly serializing CID instances. This PR adds `cleanCID` step to several functions and also updates the `cleanCID` function to not assume buffer CIDs are CIDv0 multihashes. depends on ipfs-inactive/interface-js-ipfs-core#413 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai> * fix: disable just the rule we're breaking License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai> * chore: update dependencies License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai> * fix: skip test that go-ipfs cannot pass License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.