Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

test: tests and fixes for CID version agnostic read and write #1757

Merged
merged 2 commits into from
Dec 15, 2018
Merged

test: tests and fixes for CID version agnostic read and write #1757

merged 2 commits into from
Dec 15, 2018

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Dec 7, 2018 •
edited
Loading

@ghost ghost assigned alanshaw Dec 7, 2018
@ghost ghost added the status/in-progress In progress label Dec 7, 2018
@alanshaw alanshaw changed the title [WIP] test: tests and fixes for CID version agnostic read and write test: tests and fixes for CID version agnostic read and write Dec 9, 2018
@alanshaw alanshaw mentioned this pull request Dec 9, 2018
Closed
49 tasks
@alanshaw
Copy link
Member Author

@achingbrain is this 👍 for you now?

Alan Shaw and others added 2 commits December 15, 2018 19:41
fix: CID parsing for cat/get/ls in HTTP API
2080f31 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@achingbrain
fix: disable just the rule we're breaking
f88e981 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>

Co-Authored-By: alanshaw <alan.shaw@protocol.ai>
@alanshaw alanshaw merged commit 5e555ef into master Dec 15, 2018
@ghost ghost removed the status/in-progress In progress label Dec 15, 2018
@alanshaw alanshaw deleted the test/cid-version-agnostic branch December 15, 2018 22:05
@snyk-bot snyk-bot mentioned this pull request Jul 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achingbrain achingbrain achingbrain left review comments

@hugomrdias hugomrdias hugomrdias approved these changes

@daviddias daviddias Awaiting requested review from daviddias

Assignees

@alanshaw alanshaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanshaw @hugomrdias @achingbrain