Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feat/backend toggle switch for desktop settings #30

Open
Jacekdaa opened this issue Aug 24, 2019 · 0 comments
Open

WIP: Feat/backend toggle switch for desktop settings #30

Jacekdaa opened this issue Aug 24, 2019 · 0 comments

Comments

@Jacekdaa
Copy link

@phoniks commented on Tue Dec 04 2018

Seeking feedback. I'm working on enabling the user to try out the Javascript implementation of IPFS by toggling a switch on the settings page. This PR simply ads a checkbox on the DesktopSettings page. I'm particularly interested in knowing whether having this as a checkbox makes sense. Originally I had in mind, based on the original discussions of this feature, to make this setting a select component, but during coding it became obvious that doing so would add a lot of code for not very much change in user experience. Perhaps in the future, if there are other implementations that can be chosen, it may make sense to do the dropdown, but for now it doesn't seem prudent. But, perhaps since it potentially takes your node offline there should be an intermediate step between flipping the switch and actually shutting down the node and re-spawning. Maybe a quick confirmation alert?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant