Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup render issue in Chrome #318

Closed
alanshaw opened this issue Nov 21, 2017 · 7 comments · Fixed by #441
Closed

Popup render issue in Chrome #318

alanshaw opened this issue Nov 21, 2017 · 7 comments · Fixed by #441
Labels
help wanted Seeking public contribution on this issue status/blocked/upstream-bug Blocked by upstream bugs

Comments

@alanshaw
Copy link
Member

If the popup receives an update than changes it's height whilst it is animating in then it goes bad:

screen shot 2017-11-21 at 20 07 39

@lidel lidel added help wanted Seeking public contribution on this issue status/blocked/upstream-bug Blocked by upstream bugs labels Nov 21, 2017
@lidel
Copy link
Member

lidel commented Nov 21, 2017

Hm was not able to replicate so far, seems to be specific to Chrome.

Is this the same issue as https://bugs.chromium.org/p/chromium/issues/detail?id=457887 ?
Its over 1 year old, and they prioritize things oddly (eg. it took 4 years to fix background-size), so we may want to address this on our side.

Perhaps we could detect running in Chrome and producing some kind of additional, delayed update after initial load?

@lidel
Copy link
Member

lidel commented Dec 13, 2017

@alanshaw mind checking if changes merged with #336 helped by any chance?
I suspect this is platform-specific (macOS?).

@jnthnvctr
Copy link

Hi @lidel, unfortunately I believe this is still persisting (I'm also on macOS accessing using Chrome).
Chrome version I'm on is: 63.0.3239.84

This thread had a few work arounds people had found for the bug: https://bugs.chromium.org/p/chromium/issues/detail?id=428044

lidel added a commit that referenced this issue Jan 7, 2018
- closes #338
- as a side-effect may improve situation with #318
@lidel
Copy link
Member

lidel commented Jan 10, 2018

Thanks @jnthnvctr! @olizilla was able to replicate it in #354 (comment).

tl;dr it is indeed specific to Chrome on macOS (potential explanation)

I am looking for a volunteer with a Mac to go over potential fixes in #355 :)

@lidel
Copy link
Member

lidel commented Feb 26, 2018

Seems to be fixed in current master#355 (comment)
Feel free to reopen if happens again.

@lidel lidel closed this as completed Feb 26, 2018
@olizilla
Copy link
Member

olizilla commented Apr 4, 2018

@lidel it's happening again on the beta-channel chrome release

screenshot 2018-04-04 13 12 02

also, i don't have permissions to re-open bugs on this repo, plz can haz?

@lidel
Copy link
Member

lidel commented Apr 4, 2018

@olizilla added you as collaborator – try to reopen this issue now :)

I had a potential fix shelved, so I created a PR #441 with it.
As I do not own a Mac, mind taking this over?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue status/blocked/upstream-bug Blocked by upstream bugs
Projects
None yet
4 participants