Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: IPFS_GATEWAY #94

Merged
merged 3 commits into from
Oct 18, 2022
Merged

refactor: IPFS_GATEWAY #94

merged 3 commits into from
Oct 18, 2022

Conversation

whizzzkid
Copy link
Collaborator

@whizzzkid whizzzkid commented Oct 18, 2022 •
edited
Loading

Original PR: #93

In this PR:

dag-cbor-ipfs-geoip

Remaining

  • update source dataset and regenerate b-tree, so users not only get storage savings thanks to DAG-CBOR, but also get updated GeoIP database
  • cleanup add retry if gateway timeouts
  • confirm it works with https://github.com/ipfs/ipfs-webui (refactor to use availableGatewayUrl and pass it similar to how we do it on explore page)

@whizzzkid whizzzkid mentioned this pull request Oct 18, 2022
Merged
@lidel lidel self-requested a review October 18, 2022 13:21
@lidel
feat: support IPFS_GATEWAY env
d2e7139 
ipfs/specs#280

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
lidel approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for snoke-testing!

I've restored ability to run things against local node by following convention from ipfs/specs#280 (IPFS_GATEWAY env).

Merging, let's continue in #93

@lidel lidel changed the title Improving Refactoring to DAG-CBOR refactor: IPFS_GATEWAY Oct 18, 2022
@lidel lidel merged commit 7d93596 into ipfs-shipyard:refactor/dag-cbor Oct 18, 2022
@SgtPooki
Copy link
Member

  • update source dataset and regenerate b-tree, so users not only get storage savings thanks to DAG-CBOR, but also get updated GeoIP database
  • cleanup add retry if gateway timeouts
  • confirm it works with https://github.com/ipfs/ipfs-webui (refactor to use availableGatewayUrl and pass it similar to how we do it on explore page)

@whizzzkid are these being tracked anywhere else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whizzzkid @SgtPooki @lidel