feat: enable uglify mangle and compress #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
daviddias
approved these changes
Apr 24, 2018
Any idea what causes the error? Would be nice to be able to run js-ipfs through uglify with default settings |
|
Hey @fazo96, sorry for the late response, I must've missed the notification 😐 No idea to be honest. I got that error so I figured it could be solved by passing some options, and |
This was referenced Jun 6, 2018
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Jul 14, 2018
This commit is a backport of ipfs/aegir#214 Default flags from webpack broke pubsub by removing 'unused' experiments. This restores pubsub functionality and applies the fix for entire build pipeline.
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Jul 14, 2018
This commit is a backport of ipfs/aegir#214 Default flags from webpack broke pubsub by removing 'unused' experiments. This restores pubsub functionality and applies the fix for entire build pipeline.
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Jul 16, 2018
Change webpack minimizer flags to follow Aegir ### Problem fixed by this PR Default minimizer flags break pubsub with embedded node by removing 'unused' code of pubsub experiment. Details in #521. ### In This PR - Backport of ipfs/aegir#214: it restores pubsub functionality and applies the fix for entire build pipeline to avoid similar issues in future. - The way configuration blocks are merged is improved by use of [webpack-merge](https://www.npmjs.com/package/webpack-merge) - Bundles are bit smaller due to moving LICENSE comments to separate file (`extractComments: true`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now enable mangling after changing the way we did some type checking, from comparing instances with
constructor.nameto using the class-is module that uses symbols, as proposed in ipfs/js-ipfs#1131 (comment).Check ipfs/js-ipfs#938 (comment) for some of the repos that were affected.
We can now also compress the code, but I've had to disable the
unusedflag (it drops unreferenced functions and variables -- check it) due to the following error:Fixes ipfs/js-ipfs#938.