Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubsub with embedded js-ipfs not working #521

Closed
alanshaw opened this issue Jul 11, 2018 · 2 comments · Fixed by #529
Closed

Pubsub with embedded js-ipfs not working #521

alanshaw opened this issue Jul 11, 2018 · 2 comments · Fixed by #529
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@alanshaw
Copy link
Member

I was trying to demo https://github.com/tableflip/ipfs-pubsub-chat-example at the dev meetings but wasn’t able to as it wasn’t working. Building a dev build ‘npm run watch’ fixed the issue.
@alanshaw
Copy link
Member Author

FYI I was seeing the error mentioned here: ipfs/aegir#214

@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Jul 13, 2018
@lidel lidel mentioned this issue Jul 14, 2018
Merged
lidel added a commit that referenced this issue Jul 16, 2018
@lidel
Merge pull request #529 from ipfs-shipyard/fix/pubsub-in-js-ipfs
d13a655 
Change webpack minimizer flags to follow Aegir

### Problem fixed by this PR

Default minimizer flags break pubsub with embedded node  by removing 'unused' code of pubsub experiment. Details in #521.

### In This PR

-  Backport of ipfs/aegir#214: it restores pubsub functionality and applies the fix for  entire build pipeline to avoid similar issues in future.
- The way configuration blocks are merged is improved by use of [webpack-merge](https://www.npmjs.com/package/webpack-merge)
- Bundles are bit smaller due to moving LICENSE comments to separate file (`extractComments: true`)
@lidel
Copy link
Member

lidel commented Jul 16, 2018

Fix shipped with latest Beta: v2.4.2.10430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change webpack minimizer flags to follow Aegir ipfs/ipfs-companion
2 participants
@alanshaw @lidel