Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockservice & exchange & bitswap: add non variadic NotifyNewBlock #242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

blockservice & exchange & bitswap: add non variadic NotifyNewBlock #242

wants to merge 1 commit into from

Commits on Apr 5, 2023

  1. blockservice & exchange & bitswap: add non variadic NotifyNewBlock 

    Variadicts in go are just syntactic sugar around passing a slice, that
means all go memory reachability rules apply, this force the compiler to
heap allocate the variadic slice for virtual call, because the
implementation is allowed to leak the slice (and go's interprocedural
optimisations do not cover virtuals).

Passing a block without variadic will pass the itab either on the stack
or decomposed through registers. Skipping having to allocate a slice.
    @Jorropo @hacdias
    Jorropo authored and hacdias committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    311cd1f View commit details
    Browse the repository at this point in the history