feat(gateway): IPFSBackend metrics and HTTP range support #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds spans for every IPFSBackend API call - Adds success/failure histogram for each API call ipfs_gw_backend_api_call_duration_seconds
Codecov Report
@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 47.88% 48.12% +0.23%
==========================================
Files 269 271 +2
Lines 32976 33159 +183
==========================================
+ Hits 15792 15957 +165
- Misses 15513 15534 +21
+ Partials 1671 1668 -3
|
lidel
added a commit
to ipfs-inactive/bifrost-gateway
that referenced
this pull request
Mar 31, 2023
- IPFSBackend metrics from ipfs/boxo#245 - GraphGateway metrics from #61 - Version for tracking rollouts
This was referenced Mar 31, 2023
Also fixes serving range requests for /ipfs/bafydir when we know we'll get the index.html or _redirect.
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Mar 31, 2023
Exposing metrics from ipfs/boxo#245
3 tasks
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Mar 31, 2023
Exposing metrics from ipfs/boxo#245
lidel
changed the title
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Mar 31, 2023
Exposing range fixes and new metrics from ipfs/boxo#245
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Mar 31, 2023
Exposing range fixes and new metrics from ipfs/boxo#245
blockstore can be used in contexts where there is no bitswap, and this log message will me EXTREMELY confusing, wasting people's time on debugging invalid side of system
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Apr 1, 2023
Exposing range fixes and new metrics from ipfs/boxo#245
lidel
commented
Apr 1, 2023
Comment on lines
+136
to
+140
| md, rc, errCh, err := b.api.GetCAR(ctx, path) | ||
|
|
||
| // TODO: handle errCh | ||
| b.updateApiCallMetric(name, err, begin) | ||
| return md, rc, errCh, err |
There was a problem hiding this comment.
💭 (late friday wrap-up) @aschmahmann updateApiCallMetric will increase counter for success or failure based on err. Are we missing anything critical if we only check err here and ignore errCh?
(This should not block this PR, we can fix metric later)
lidel
commented
Apr 1, 2023
There was a problem hiding this comment.
@aschmahmann @hacdias I think this is ready for review.
TLDR: adds metrics, fixes range requests, merges Get and GetRange into one func.
Sharness in Kubo PR is green: ipfs/kubo#9786
| @@ -244,7 +244,7 @@ func getBlock(ctx context.Context, c cid.Cid, bs blockstore.Blockstore, fget fun | |||
|
|
|||
| // TODO be careful checking ErrNotFound. If the underlying | |||
| // implementation changes, this will break. | |||
| logger.Debug("Blockservice: Searching bitswap") | |||
| logger.Debug("BlockService: Searching") | |||
There was a problem hiding this comment.
ℹ️ there is no bitswap in bifrost-gateway, yet we got super confusing "Searching bitswap" message here ;)
| // - A range request for a directory currently holds no semantic meaning. | ||
| // | ||
| // [HTTP Byte Ranges]: https://httpwg.org/specs/rfc9110.html#rfc.section.14.1.2 | ||
| Get(context.Context, ImmutablePath, ...ByteRange) (ContentPathMetadata, *GetResponse, error) |
There was a problem hiding this comment.
ℹ️ removed GetRange, we now have Get with optional range requests
hacdias
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of ipfs-inactive/bifrost-gateway#61
gateway/metrics.goTODO
GetandGetRangeare now the same, as suggested in feat: switch gateway GetRange API to match Get #240 (review)