-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitswap/client: add basic traceable blocks #308
Conversation
This needs tests ! |
Also a changelog update? |
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
==========================================
- Coverage 49.71% 49.19% -0.52%
==========================================
Files 248 245 -3
Lines 29933 29870 -63
==========================================
- Hits 14882 14696 -186
- Misses 13619 13746 +127
+ Partials 1432 1428 -4
|
4537dcf
to
a6bfd5e
Compare
Any ETA to add the tests? |
a6bfd5e
to
be83933
Compare
also added Changelog, though I don't know if you all have a preferred format. |
Following up: @BigLep this still isn't merged. It's not clear what's blocking -- can we move this along? |
@hannahhoward my time is blocking, this is the next thing on the list https://github.com/orgs/ipfs/projects/16/views/17 and will get in for the next boxo release. BTW This PR is not needed for the requirement that we passed in the slack thread, this was under nice to have. |
I know there has been chatter about this in Slack. This PR will get landed this week as we'll include it in Kubo 0.22, which we're pushing to get an RC out ASAP. |
Co-authored-by: Henrique Dias <hacdias@gmail.com>
5acf562
to
e886cf5
Compare
Fixes #209