gateway/assets: process each template and ETag hash in parallel #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: ``` init github.com/ipfs/boxo/gateway/assets @26 ms, 18 ms clock, 9887320 bytes, 1496 allocs ``` To: ``` init github.com/ipfs/boxo/gateway/assets @10 ms, 3.3 ms clock, 3368 bytes, 11 allocs ``` This is not optimal but better solutions (like lazy loading) require breaking the API and it's a better job for future someone else.
Jorropo
force-pushed
the
gateway/assets/parallel-compute
branch
from
2e320fd
to
2fdb4a9
Compare
Codecov ReportAttention:
@@ Coverage Diff @@
## main #530 +/- ##
==========================================
+ Coverage 65.62% 65.64% +0.02%
==========================================
Files 207 207
Lines 25549 25559 +10
==========================================
+ Hits 16766 16778 +12
+ Misses 7317 7314 -3
- Partials 1466 1467 +1
|
hacdias
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From:
To:
This is not optimal but better solutions (like lazy loading) require breaking the API and it's a better job for future someone else.
(the less allocs is missleading
inittraceonly tracks the init goroutine)