feat(routing/none): remove nil router #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #621 +/- ##
==========================================
+ Coverage 59.67% 60.53% +0.86%
==========================================
Files 239 238 -1
Lines 29961 29537 -424
==========================================
+ Hits 17879 17881 +2
+ Misses 10460 10034 -426
Partials 1622 1622 |
ribasushi
added a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Jun 18, 2024
ribasushi
added a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Jun 18, 2024
rvagg
pushed a commit
to filecoin-project/lotus
that referenced
this pull request
Jun 19, 2024
ribasushi
added a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Jun 19, 2024
gammazero
approved these changes
Jun 19, 2024
aschmahmann
force-pushed
the
feat/old-nil-router
branch
from
7390014
to
7e1497e
Compare
ribasushi
added a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #620
This removes the nil router, if people would prefer something less harsh (e.g. deprecation followed by removal, stubbing followed by deprecation + removal) comment on the issue above