Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stalebot workflow to all repositories #4

Merged
merged 5 commits into from
Jun 13, 2022
Merged

add stalebot workflow to all repositories #4

merged 5 commits into from
Jun 13, 2022

Conversation

galargh
Copy link
Contributor

@galargh galargh commented May 6, 2022

This will distribute the stale.yml workflow to go-ipfs repository.

I have verified that go-ipfs contains need/author-input label. FYI, we'll be able to manage labels through GitHub Management once data source for labels is added to the GitHub Terraform provider.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

Terraform plans are too long to post as a comment. Please inspect Plan > Comment > Show terraform plans instead.

@galargh galargh requested a review from lidel May 6, 2022 11:23
@galargh
Copy link
Contributor Author

galargh commented May 9, 2022

I created a bash script which checks if repo labels required by stale.yml and if so it adds the workflow to said repository. Let me know if you think we should start with a subset of the repos instead.

@galargh
Copy link
Contributor Author

galargh commented May 9, 2022

FYI, the plan run is failing to comment on this PR because the terraform plan it wants to include in the comment is too long. I'll think about what to do in such situations. I'm thinking preserving the message on the workflow run and posting a link might do the trick.

@galargh galargh force-pushed the master branch 4 times, most recently from 00c07bd to fd82df8 Compare May 9, 2022 13:46
@galargh galargh changed the title add stale workflow to go-ipfs add stale workflow to all repositories that have required labels May 9, 2022
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️ Small asks below.

scripts/ensure-stale-workflow-is-in-all-repos.sh Outdated Show resolved Hide resolved
scripts/ensure-stale-workflow-is-in-all-repos.sh Outdated Show resolved Hide resolved
@galargh
Copy link
Contributor Author

galargh commented May 23, 2022

@lidel What do you think about this after applying the suggested changes? Do you think we could proceed with this?

@BigLep BigLep added this to the Best Effort Track milestone May 25, 2022
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would like to get explicit 👍 from @achingbrain as we add this bot to many JS repos.

also cc'd folks involved in various triages for visibility
@BigLep @guseggert @aschmahmann @SgtPooki @ajnavarro

files/.github/workflows/stale.yml Outdated Show resolved Hide resolved
@lidel lidel changed the title add stale workflow to all repositories that have required labels add stalebot workflow to all repositories May 27, 2022
@lidel lidel requested a review from achingbrain May 27, 2022 23:30
@galargh
Copy link
Contributor Author

galargh commented Jun 6, 2022

@achingbrain Are you OK with proceeding with this?

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galargh we discussed this during GO and JS triages last Friday, and we really want this (@achingbrain is 👍), but we also realized the setup is missing a way to exempt certain sensitive types of issue/PRs from being closed.

Sometimes we mark an issue as need/author-input but don't want it to be automatically closed when there is no answer from the author (for example, things we do want to do/fix/understand anyway, but hope to get some feedback from the original author before actual work happens).

See proposed fix below.

files/.github/workflows/stale.yml Show resolved Hide resolved
galargh and others added 2 commits June 13, 2022 09:29
Co-authored-by: Marcin Rataj <lidel@lidel.org>
ensure we don't close things that remain actionable
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – @galargh ok to merge?

Applied exempt-issue-labels: 'need/triage,need/community-input,need/maintainer-input,need/maintainers-input,need/analysis'
It will protect us from autoclosing things that are waiting for things other than author input.

@galargh galargh merged commit d3e4f08 into master Jun 13, 2022
@galargh
Copy link
Contributor Author

galargh commented Jun 13, 2022

LGTM – @galargh ok to merge?

Applied exempt-issue-labels: 'need/triage,need/community-input,need/maintainer-input,need/maintainers-input,need/analysis' It will protect us from autoclosing things that are waiting for things other than author input.

Merged! Unexpected (but totally predictable) consequence - it kicked off CI in all the repos so we're going to be a bit backed up for a little bit in terms of available runners.

@galargh galargh deleted the stale branch June 13, 2022 13:04
ipfs-mgmt-read-write bot pushed a commit that referenced this pull request Jul 6, 2022
ipfs-mgmt-read-write bot pushed a commit that referenced this pull request Jul 9, 2022
galargh added a commit that referenced this pull request Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants