-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stalebot workflow to all repositories #4
Conversation
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform plansTerraform plans are too long to post as a comment. Please inspect Plan > Comment > Show terraform plans instead. |
I created a bash script which checks if repo labels required by |
FYI, the plan run is failing to comment on this PR because the terraform plan it wants to include in the comment is too long. I'll think about what to do in such situations. I'm thinking preserving the message on the workflow run and posting a link might do the trick. |
00c07bd
to
fd82df8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! ❤️ Small asks below.
@lidel What do you think about this after applying the suggested changes? Do you think we could proceed with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but would like to get explicit 👍 from @achingbrain as we add this bot to many JS repos.
also cc'd folks involved in various triages for visibility
@BigLep @guseggert @aschmahmann @SgtPooki @ajnavarro
@achingbrain Are you OK with proceeding with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@galargh we discussed this during GO and JS triages last Friday, and we really want this (@achingbrain is 👍), but we also realized the setup is missing a way to exempt certain sensitive types of issue/PRs from being closed.
Sometimes we mark an issue as need/author-input
but don't want it to be automatically closed when there is no answer from the author (for example, things we do want to do/fix/understand anyway, but hope to get some feedback from the original author before actual work happens).
See proposed fix below.
Co-authored-by: Marcin Rataj <lidel@lidel.org>
ensure we don't close things that remain actionable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM – @galargh ok to merge?
Applied exempt-issue-labels: 'need/triage,need/community-input,need/maintainer-input,need/maintainers-input,need/analysis'
It will protect us from autoclosing things that are waiting for things other than author input.
Merged! Unexpected (but totally predictable) consequence - it kicked off CI in all the repos so we're going to be a bit backed up for a little bit in terms of available runners. |
This will distribute the stale.yml workflow to go-ipfs repository.
I have verified that
go-ipfs
containsneed/author-input
label. FYI, we'll be able to manage labels through GitHub Management once data source for labels is added to the GitHub Terraform provider.