This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
feat: add a custom CID type #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dirkmc
approved these changes
Mar 19, 2020
Should be. But let me add a quick test. |
This allows us to marshal/unmarshal/size protobufs without copying CID around.
Stebalien
force-pushed
the
feat/custom-cid-type
branch
from
35db51b
to
4b91e9b
Compare
|
Ok, I've added a test with a known-good message with a CID. |
|
Awesome thank you 👍 |
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
feat: add a custom CID type This commit was moved from ipfs/go-bitswap@21d8834
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to marshal/unmarshal/size protobufs without copying CID around.