This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Improve peer manager performance #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
May 20, 2020
| // Send cancels to a particular peer | ||
| send := func(p peer.ID, pws *peerWant) { | ||
| // Include broadcast cancels | ||
| peerCancels := append(cancelsBuff[:0], broadcastKs...) |
There was a problem hiding this comment.
nit: you don't have to copy these every time.
There was a problem hiding this comment.
You're right, good idea 💡 I updated the benchmark stats above
Stebalien
reviewed
May 21, 2020
| // Send cancels to a particular peer | ||
| send := func(p peer.ID, pws *peerWant) { | ||
| // Start the index into the buffer after the broadcast wants | ||
| i = broadcastKsCount |
There was a problem hiding this comment.
Suggested change
| i = broadcastKsCount | |
| i := broadcastKsCount |
Instead of tracking offsets, just create a "new" slice starting with the broadcast cancel slice. Under the covers, this will just use the same memory over and over.
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
Improve peer manager performance This commit was moved from ipfs/go-bitswap@0730042
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #392
Roughly 4x improvement with a somewhat contrived benchmark: