cleanup and optimize naive query filters #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
force-pushed
the
fix/cleanup-query
branch
from
3825faa
to
09cb36c
Compare
It's impossible to cancel this correctly. This patch also tries to avoid goroutines whenever possible.
Stebalien
force-pushed
the
fix/cleanup-query
branch
from
09cb36c
to
b086f25
Compare
michaelavila
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly, avoid ResultsWithChan as it isn't possible to properly cancel a query with this helper. We were also, somehow, concurrently calling close and next (which was breaking a different PR I'm working on).
This should also improve performance by getting rid of a bunch of goroutines.