Ignore non-directories in the top level directory. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage increased (+1.5%) to 61.935% when pulling 9e8816958a3b094045102f4a1640f5739062572d on kevina/non-file-ignore into 1db836c on master. |
kevina
force-pushed
the
kevina/non-file-ignore
branch
from
9e88169
to
b1e7324
Compare
whyrusleeping
requested changes
Dec 7, 2016
| @@ -343,6 +343,8 @@ func testQuerySimple(dirFunc mkShardFunc, t *testing.T) { | |||
| temp, cleanup := tempdir(t) | |||
| defer cleanup() | |||
|
|
|||
| ioutil.WriteFile(filepath.Join(temp, "README"), []byte("something"), 0666) | |||
There was a problem hiding this comment.
might want to check that this doesnt error, just in case (if it errors and fails to create the file, then the test would pass regardless of the above fix)
There was a problem hiding this comment.
oops, oversight on my part sorry.
Ignore non-directories in the top level directory to allow placing a README or similar file there.
kevina
force-pushed
the
kevina/non-file-ignore
branch
from
b1e7324
to
7ec19f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore non-directories in the top level directory to allow placing a README or similar file there.
This is based on #6.