Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks can be zero sized #107

Open
Stebalien opened this issue Oct 20, 2020 · 1 comment
Open

Blocks can be zero sized #107

Stebalien opened this issue Oct 20, 2020 · 1 comment
Labels
need/triage Needs initial labeling and prioritization P2 Medium: Good to have, but can wait until someone steps up

Comments

@Stebalien
Copy link
Member

Currently, if we send a zero-size block, we won't process block hooks, etc. This case may actually be fine, but we can't assume that a zero block size implies no block.
@Stebalien Stebalien added the need/triage Needs initial labeling and prioritization label Oct 20, 2020
@hannahhoward hannahhoward added the P2 Medium: Good to have, but can wait until someone steps up label Sep 28, 2021
@hannahhoward
Copy link
Collaborator

I'm pretty sure this is not still an issue? Need to revisit

marten-seemann pushed a commit that referenced this issue Mar 2, 2023
@hannahhoward
fix(impl): don't error when channel missing (#107)
7f08cb3 
When close is called, if the node has restarted, likely there is no open
channel. Therefore, we should not error, and, instead, just log a
warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @hannahhoward