Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tracing span collection #324

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Fix tracing span collection #324

merged 1 commit into from
Jan 4, 2022

Conversation

hannahhoward
Copy link
Collaborator

Goals

Caught this working with tracing over in go-data-transfer. I'm not sure what causes ExportSpans to get called multiple times -- over a fixed number? some kind of context cancellation? Not sure. Anyway, if it does, we were losing spans.

Implementation

Append span list rather than overwriting it on export.

collect all spans if export spans is called more than once
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, unexpected, but I suppose that's reasonable, good catch

@rvagg rvagg merged commit 8e9f6cf into main Jan 4, 2022
@rvagg rvagg deleted the fix/span-collection branch January 4, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants