allow configuration of ipldStores default hash function #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Jan 26, 2023
| @@ -89,7 +93,11 @@ type cidProvider interface { | |||
|
|
|||
| // Put marshals and writes content `v` to the backing blockstore returning its CID. | |||
| func (s *BasicIpldStore) Put(ctx context.Context, v interface{}) (cid.Cid, error) { | |||
| mhType := uint64(mh.BLAKE2B_MIN + 31) | |||
| mhType := DefaultMultihash | |||
| if s.DefaultMultihash != 0 { | |||
There was a problem hiding this comment.
Hm.... this technically conflicts with the identity hash. I mean, that doesn't make sense as the default anyways, so maybe we're fine.
There was a problem hiding this comment.
I guess I could make it a pointer?
There was a problem hiding this comment.
though if you really want the identity hash you can use the cid provider thing right?
There was a problem hiding this comment.
Yep. And, honestly, you shouldn't make the default "identity". That's just absolutely stupid.
Stebalien
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.