Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: ErrNotFound hopefully final #72

Merged
merged 2 commits into from
Apr 2, 2022
Merged

Feat: ErrNotFound hopefully final #72

merged 2 commits into from
Apr 2, 2022

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Mar 31, 2022

@Jorropo Jorropo self-assigned this Mar 31, 2022
@Jorropo Jorropo requested a review from guseggert March 31, 2022 21:01
This was referenced Mar 31, 2022
Merged
Merged
schomatis
schomatis reviewed Apr 1, 2022
View reviewed changes
Copy link
Contributor

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm lacking context but it's a bit weird that the callee qualifies it's own error. It's usually the caller that wraps it if needed.

Do we somehow depend on the text being redefined here? Is that why we're bumping the minor version?

schomatis
schomatis approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this has been discussed and approved in ipfs/go-ipfs-http-client#156 (comment).

@Jorropo Jorropo merged commit 0f7aff0 into ipfs:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schomatis schomatis schomatis approved these changes

@guseggert guseggert Awaiting requested review from guseggert

Assignees

@Jorropo Jorropo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jorropo @schomatis