Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump go-ipld-format v0.4.0 and fix related sharness tests #8838

Merged
merged 3 commits into from
Apr 5, 2022
Merged

chore: bump go-ipld-format v0.4.0 and fix related sharness tests #8838

merged 3 commits into from
Apr 5, 2022

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Mar 31, 2022 •
edited
Loading

@Jorropo Jorropo requested a review from guseggert March 31, 2022 21:04
@Jorropo Jorropo self-assigned this Mar 31, 2022
@Jorropo Jorropo force-pushed the fix/ErrNotFound-hopefully-final branch from a6ee61d to 4c76567 Compare March 31, 2022 22:38
@Jorropo Jorropo mentioned this pull request Mar 31, 2022
Merged
3 tasks
@Jorropo Jorropo force-pushed the fix/ErrNotFound-hopefully-final branch 11 times, most recently from a1cb08e to 16a13ce Compare April 1, 2022 03:06
schomatis
schomatis suggested changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jorropo Can we fix lint and related errors to have CI pass? It's hard to tell if this is fixing previously existing errors if new ones are blocking the build.

@Jorropo Jorropo force-pushed the fix/ErrNotFound-hopefully-final branch from 85a6dd5 to a126fbc Compare April 1, 2022 16:13
@Jorropo Jorropo requested a review from schomatis April 1, 2022 16:14
@Jorropo
Copy link
Contributor Author

Jorropo commented Apr 1, 2022

@schomatis done!

@Jorropo Jorropo force-pushed the fix/ErrNotFound-hopefully-final branch from a126fbc to ac297a8 Compare April 2, 2022 03:08
@lidel lidel mentioned this pull request Apr 4, 2022
Merged
@Jorropo
Copy link
Contributor Author

Jorropo commented Apr 5, 2022

Merging as discussed in today's meeting.

@Jorropo Jorropo enabled auto-merge April 5, 2022 18:10
@Jorropo Jorropo disabled auto-merge April 5, 2022 18:10
@Jorropo Jorropo enabled auto-merge April 5, 2022 18:27
@Jorropo Jorropo disabled auto-merge April 5, 2022 18:31
@Jorropo Jorropo enabled auto-merge April 5, 2022 18:31
@Jorropo Jorropo merged commit 4df7b79 into ipfs:master Apr 5, 2022
@Jorropo Jorropo deleted the fix/ErrNotFound-hopefully-final branch April 5, 2022 19:08
@lidel lidel mentioned this pull request Apr 29, 2022
Closed
@lidel lidel mentioned this pull request Jul 19, 2022
Merged
@Jorropo Jorropo restored the fix/ErrNotFound-hopefully-final branch December 12, 2022 22:32
@Jorropo Jorropo deleted the fix/ErrNotFound-hopefully-final branch December 12, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schomatis schomatis schomatis approved these changes

@guseggert guseggert Awaiting requested review from guseggert

Assignees

@Jorropo Jorropo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jorropo @schomatis