This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Fix directory mv and add tests #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Naming changes for my personal comprehension * Add a few tests covering simple mv cases (including our bug) * Fix bug in Mv that would leave fail to delete src directories (when named without a trailing slash) after copying them to their new location
ghost
assigned
eingenito
commented
May 8, 2019
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if srcDir == dstDirStr && srcFname == filename { | ||
| if srcDir.name == dstDir.name && srcFname == dstFname { |
There was a problem hiding this comment.
This is the only substantive change in this file and is the actual source of the bug revealed in go-ipfs sharness tests. Everything else is naming changes (which I can totally revert if it's too noisy).
Stebalien
approved these changes
May 9, 2019
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
Fix directory mv and add tests This commit was moved from ipfs/go-mfs@94b38c2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the go-ipfs tests: https://circleci.com/gh/ipfs/go-ipfs/tree/fix%2Fmfs-regression