Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improvements & gateway-conformance support (light) #57

Merged
merged 27 commits into from
Dec 6, 2023

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Dec 4, 2023

This certainly isn't done yet (and not just because we don't pass the conformance tests yet). For example, the environment variables to help enable subdomain gateway tests are not wired up yet. Wanted to see how close this approach was to working though.

Closes #30

Note: In addition to many tests failing, a number of them aren't showing up because some of the failures are killing the gateway-conformance tester due to this unresolved issue https://github.com/ipfs/gateway-conformance/blob/d855ec4fb9dac4a5aaecf3776037b005cc74c566/tooling/check/check.go#L358

@aschmahmann aschmahmann force-pushed the ci/gateway-conformance branch 2 times, most recently from 1b7ee7d to 8aa0368 Compare December 4, 2023 06:17
@SgtPooki
Copy link
Member

SgtPooki commented Dec 4, 2023

I don't think the gateway conformance test proxying works well with helia-http-gateway. something is up.. The test for url http://localhost:8090/ipns/QmVujd5Vb7moysJj8itnGufN7MEtPRCNHkKpNuA4onsRa3, titled "TestGatewaySubdomainAndIPNS/request_for_%2Fipns%2F%7BCIDv0%7D_redirects_to_CIDv1_with_libp2p-key_multicodec_in_subdomain_%28HTTP_proxy%29", says that it fails, proxyconnect tcp: dial tcp [::1]:8090: connect: connection refused, but when I testhttp://localhost:8090/ipns/QmVujd5Vb7moysJj8itnGufN7MEtPRCNHkKpNuA4onsRa3 in my browser, it works fine.

Is there a reason gateway-conformance is trying to use ipv6 addresses but reporting that it's trying to connect to localhost:8090 ?

Also, a lot of requests are requesting localhost/ instead of localhost:port and proxying them. this could be an issue with docker on my mac.. I will try without docker and see if I get similar errors.

@SgtPooki
Copy link
Member

SgtPooki commented Dec 4, 2023

Also, a lot of requests are requesting localhost/ instead of localhost:port and proxying them. this could be an issue with docker on my mac.. I will try without docker and see if I get similar errors.

I confirmed that things are working much better running gateway-conformance directly with go run ./cmd/gateway-conformance/main.go test --gateway-url 'http://localhost:8090' --subdomain-url 'http://localhost:8090' --json gwc-report.json --specs subdomain-ipns-gateway -- -timeout 30m. I was able to get 9 passing tests this way.

@SgtPooki
Copy link
Member

SgtPooki commented Dec 4, 2023

The report is currently too big for an upload, so I reduced the specs to just subdomain ipfs and ipns for now:

Error: $GITHUB_STEP_SUMMARY upload aborted, supports content up to a size of 1024k, got 1073k. For more information see: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#adding-a-markdown-summary

@SgtPooki
Copy link
Member

SgtPooki commented Dec 6, 2023

FYI: all gateway-conformance tests are disabled, but a lot of improvements are here that I want on the main branch. sorry folks.

@SgtPooki SgtPooki changed the title ci: add gateway-conformance tests feat: improvements & gateway-conformance support (light) Dec 6, 2023
@SgtPooki SgtPooki merged commit 23f467f into main Dec 6, 2023
3 checks passed
@SgtPooki SgtPooki deleted the ci/gateway-conformance branch December 6, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: enable gateway-conformance tests
3 participants