Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files: drag&drop target is to small #916

Closed
lidel opened this issue Dec 20, 2018 · 1 comment
Closed

Files: drag&drop target is to small #916

lidel opened this issue Dec 20, 2018 · 1 comment
Assignees
Labels
exp/intermediate Prior experience is likely helpful P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Dec 20, 2018

Problem

Right now, only the file list seems to be the drop target, which makes it not only a chore to aim, but impossible to drag-and-drop into an empty directory, as the file dropped on .. (the only item in empty directory) gets added to parent directory:

peek 2018-12-20 11-42

Solution Ideas

  • the whole viewport should be the drop target
    • Ideally, even if user is not on Files screen
  • unless user drops on a specific directory on Files screen, then file is added to currently opened directory or /
  • there should be a visual cue "Drop here to add to " to ensure user it is safe to drop at the current target
@olizilla
Copy link
Member

Strongly agree. I'm not clear on why we didn't make the whole viewport the drop target in the first place. @hacdias I know you had a reason, can you explain? We really need a solution to this. I'd say being able to drop anywhere is more important than being able to drop on a dir in the filelist if we have to choose, though I think we can have both.

@olizilla olizilla added exp/intermediate Prior experience is likely helpful P1 High: Likely tackled by core team if no one steps up labels Jan 7, 2019
@olizilla olizilla mentioned this issue Jan 7, 2019
10 tasks
@fsdiogo fsdiogo self-assigned this Jan 18, 2019
@fsdiogo fsdiogo added the status/in-progress In progress label Jan 18, 2019
fsdiogo added a commit that referenced this issue Jan 24, 2019
- The dropzone was extended to the whole page
- We can now drop a file in any page: it is added to the root folder and the user redirected to the files page
- In the files page we can still drop the files in specific folders as before

![dropit](https://user-images.githubusercontent.com/33324750/51401787-98b0e780-1b43-11e9-965c-493dd9f4e2bd.gif)


Closes #916.
@ghost ghost removed the status/in-progress In progress label Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Development

No branches or pull requests

3 participants